ARROW-9369: [Python] Support conversion from python sequence to dictionary type#8008
Closed
kszucs wants to merge 6 commits into
Closed
ARROW-9369: [Python] Support conversion from python sequence to dictionary type#8008kszucs wants to merge 6 commits into
kszucs wants to merge 6 commits into
Conversation
pitrou
reviewed
Aug 20, 2020
| DICTIONARY_BINARY_LIKE(BINARY, BinaryType); | ||
| DICTIONARY_BINARY_LIKE(STRING, StringType); | ||
| // DICTIONARY_BINARY_LIKE(LARGE_BINARY, LargeBinaryType); | ||
| // DICTIONARY_BINARY_LIKE(LARGE_STRING, LargeStringType); |
Member
There was a problem hiding this comment.
Is there a reason this isn't enabled? Is the PR unfinished?
Member
Author
There was a problem hiding this comment.
Yes, there are a couple of design decisions we need to make because of the following problems:
- the index key type is ignored since adaptive builder is used
- large binary/string types are not supported by the builder which I'm not sure whether is intentional or not
| Concrete class for dictionary-encoded scalars. | ||
| """ | ||
|
|
||
| def __init__(self, index, dictionary, type): |
Member
There was a problem hiding this comment.
Maybe we can put this in some from_.. class method? (to keep it consistent with the other scalars that __init__ raises)
Member
There was a problem hiding this comment.
(and can you also add some tests for this construction method?)
pitrou
reviewed
Aug 25, 2020
| Status AppendValue(PyObject* obj) override { | ||
| ARROW_ASSIGN_OR_RAISE(string_view_, ValueConverter<ValueType>::FromPython(obj)); | ||
| // DCHECK_GE(string_view_.size, 0); | ||
| RETURN_NOT_OK(this->typed_builder_->Append(string_view_.bytes, |
Member
There was a problem hiding this comment.
Isn't there a TypedBuilder::Append(string_view)? If not, can you please add it?
| public: | ||
| Status AppendValue(PyObject* obj) override { | ||
| ARROW_ASSIGN_OR_RAISE(string_view_, ValueConverter<ValueType>::FromPython(obj)); | ||
| // DCHECK_GE(string_view_.size, 0); |
| Status AppendValue(PyObject* obj) override { | ||
| ARROW_ASSIGN_OR_RAISE( | ||
| string_view_, ValueConverter<FixedSizeBinaryType>::FromPython(obj, byte_width_)); | ||
| RETURN_NOT_OK(this->typed_builder_->Append(string_view_.bytes, |
Member
There was a problem hiding this comment.
Same here: it would be good to have TypedBuilder::Append(string_view).
| } | ||
|
|
||
| protected: | ||
| int32_t byte_width_; |
| std::shared_ptr<DecimalType> decimal_type_; | ||
| }; | ||
|
|
||
| #define DICTIONARY_PRIMITIVE(TYPE_ENUM, TYPE_CLASS) \ |
| assert isinstance(a.type, pa.DictionaryType) | ||
| assert a.type.equals(typ) | ||
|
|
||
| expected_indices = pa.array([0, 1, 0, 0, 1, 2], type=pa.int8()) |
Member
There was a problem hiding this comment.
Can you test with nulls at some point?
| def test_dictionary_from_strings(): | ||
| for value_type in [pa.binary(), pa.string()]: | ||
| typ = pa.dictionary(pa.int8(), value_type) | ||
| a = pa.array(["", "a", "bb", "a", "bb", "ccc"], type=typ) |
| with pytest.raises(pa.ArrowNotImplementedError): | ||
| pickle.loads(pickle.dumps(s)) | ||
| restored = pickle.loads(pickle.dumps(s)) | ||
| assert restored.equals(s) |
Member
There was a problem hiding this comment.
This should be inside the loop.
(also, null values are not tested?)
Member
Author
|
We can close this in favor of #8088 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.